Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Gluster Servers query
......................................................................
Patch Set 8: (4 inline comments)
Incorporated review comments.
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 489: select
fn_db_add_config_value('NetworkConnectivityCheckTimeoutInSeconds','120','general');
Line 490: -- AutoRecoveryConfiguration
Line 491: select fn_db_add_config_value('AutoRecoveryAllowedTypes','{\"storage
domains\":\"false\",\"hosts\":\"false\"}','general');
Line 492: -- Gluster peer status command
Line 493: select fn_db_add_config_value('GlusterPeerStatusCommand','gluster
peer status --xml','general');
Done
Line 494:
Line 495:
Line 496:
------------------------------------------------------------------------------------
Line 497: -- Update with override section
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersQuery.java
Line 53:
Line 54: @Override
Line 55: protected void executeQueryCommand() {
Line 56: if (connect(getParameters().getServerName())) {
Line 57: validateFingerprint();
I am not connecting twice. As you mentioned I am fetching the fingerprint from
the existing connection only.
Line 58:
Line 59: String glusterServers = executeCommand();
Line 60:
Line 61: if (StringUtils.isNotEmpty(glusterServers)) {
Line 61: if (StringUtils.isNotEmpty(glusterServers)) {
Line 62: DocumentBuilderFactory docBuilderFactory =
DocumentBuilderFactory.newInstance();
Line 63: DocumentBuilder docBuilder;
Line 64: try {
Line 65: File returnXml = new
File(System.getProperty("java.io.tmpdir") + "/peers.xml");
Removed the file creation code.
Line 66: FileWriter xmlFileWriter = new
FileWriter(returnXml);
Line 67: xmlFileWriter.write(glusterServers);
Line 68: xmlFileWriter.close();
Line 69: docBuilder =
docBuilderFactory.newDocumentBuilder();
Line 66: FileWriter xmlFileWriter = new
FileWriter(returnXml);
Line 67: xmlFileWriter.write(glusterServers);
Line 68: xmlFileWriter.close();
Line 69: docBuilder =
docBuilderFactory.newDocumentBuilder();
Line 70: Document doc = docBuilder.parse(returnXml);
Done
Line 71: // normalize text representation
Line 72: doc.getDocumentElement().normalize();
Line 73: NodeList listOfPeers =
doc.getElementsByTagName(PEER);
Line 74:
--
To view, visit http://gerrit.ovirt.org/7584
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic69a9a48bf227c8fa805c8aa9c4f08fa36ea9425
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
