Dhandapani Gopal has posted comments on this change.
Change subject: engine: Get Gluster Servers query
......................................................................
Patch Set 10: (3 inline comments)
Incorporated review comments.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersQuery.java
Line 77: String errMsg = "Could not get the peer list form the
host: " + getParameters().getServerName();
Line 78: log.error(errMsg);
Line 79: throw new RuntimeException(errMsg);
Line 80: }
Line 81: } catch (ParserConfigurationException e1) {
Done
Line 82: log.errorFormat("There is problem in parsing xml." +
e1.getMessage());
Line 83: throw new RuntimeException(e1);
Line 84: } catch (SAXException e2) {
Line 85: log.errorFormat("Error in parsing xml." + e2.getMessage());
Line 103: throw new RuntimeException(errMsg);
Line 104: }
Line 105: }
Line 106:
Line 107: protected SSHClient createSSHClient() {
Done
Line 108: return new SSHClient();
Line 109: }
Line 110:
Line 111: protected SSHClient connect(String serverName) {
Line 139: String m =
Line 140: String.format("SSH error running command %1$s
'%2$s': %3$s",
Line 141: getParameters().getServerName(),
Line 142: command,
Line 143: e.getMessage());
Removed getMessage().
Line 144: log.error(m, e);
Line 145: throw new RuntimeException(e);
Line 146: }
Line 147: return cliOutput;
--
To view, visit http://gerrit.ovirt.org/7584
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic69a9a48bf227c8fa805c8aa9c4f08fa36ea9425
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
