Dhandapani Gopal has posted comments on this change.

Change subject: engine: Get Gluster Servers query
......................................................................


Patch Set 9: (2 inline comments)

Incorporated review comments.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersQuery.java
Line 172:     }
Line 173: 
Line 174:     protected String getFingerprint(String hostName) {
Line 175:         try {
Line 176:             connect(hostName);
Done
Line 177:             return getFingerprint();
Line 178:         } finally {
Line 179:             disconnect();
Line 180:         }


Line 179:             disconnect();
Line 180:         }
Line 181:     }
Line 182: 
Line 183:     protected String getFingerprint() {
Done
Line 184:         PublicKey serverKey = this.client.getServerKey();
Line 185:         if (serverKey == null) {
Line 186:             log.error("Could not get server key");
Line 187:             return null;


--
To view, visit http://gerrit.ovirt.org/7584
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic69a9a48bf227c8fa805c8aa9c4f08fa36ea9425
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to