Alexander Wels has posted comments on this change. Change subject: restapi: optimize getUriBuilder ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/37988/2/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java: Line 813: Collection collection = getCollection(model, suggestedParentType); Line 814: if (collection == null) { Line 815: return null; Line 816: } Line 817: UriBuilder uriBuilder = builderMap.get(collection); > I executed this with the debugger and I saw that the objects in the cache d Certainly, I am working on the equals/hashcode right now, I will do the test again to see if there is something I missed. Line 818: Line 819: if (uriBuilder == null) { Line 820: Line 821: if (collection.getParentType() != NO_PARENT) { -- To view, visit http://gerrit.ovirt.org/37988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86221e8af24da28a7137c0cc0e7aec69943a65c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
