Alexander Wels has posted comments on this change. Change subject: restapi: optimize getUriBuilder ......................................................................
Patch Set 1: Verified+1 (1 comment) Verified that this changes reduced the time it took to return getVms() by about 100ms on a request that took 450ms. http://gerrit.ovirt.org/#/c/37988/1/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java: Line 800: /** Line 801: * Cache the {@code UriBuilder}s by the associated model so we don't have to create the builders each time. Line 802: */ Line 803: private static Map<Class<? extends BaseResource>, UriBuilder> builderMap = Line 804: new ConcurrentHashMap<Class<? extends BaseResource>, UriBuilder>(); We might even not need the ConcurrentHashMap here. Line 805: Line 806: /** Line 807: * Create a #UriBuilder which encapsulates the path to an object Line 808: * -- To view, visit http://gerrit.ovirt.org/37988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86221e8af24da28a7137c0cc0e7aec69943a65c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
