Alexander Wels has posted comments on this change. Change subject: restapi: optimize getUriBuilder ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37988/1/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java File backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/LinkHelper.java: Line 843: } else { Line 844: //We need to clone so we have our own copy to work with. Cloning is much faster than building a new one Line 845: //from scratch each time. Line 846: uriBuilder = uriBuilder.clone(); Line 847: } > I'm not sure if this will work correctly in all cases. Take into account th You make a good point, luckily for me the problem was already solved somewhere else in the helper class. So I used that to key my map. Line 848: Line 849: return uriBuilder.path(model.getId()); Line 850: } Line 851: -- To view, visit http://gerrit.ovirt.org/37988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86221e8af24da28a7137c0cc0e7aec69943a65c5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
