Alexander Wels has posted comments on this change. Change subject: restapi: optimize getUriBuilder ......................................................................
Patch Set 3: Verified+1 The previous patch had the following issue. Since this is a builder if I stored a builder for /vms/<vm guid>/disks in the cache the it wouldn't actually override <vm guid> when I present a new vm guid, it would append, so you would end up with strange things like /vms/<vm guid1>/disks/<disk guid>/<disk guid> and things of that nature. This patchset fixes that issue so it actually recursively looks up the appropriate builder which more or less negates the benefit of the cache (there is some benefit still but not as much). However in combination with the change to the AbstractBackendResource where I re-use the same builder for each sub collection (a clone). This still gives a significant improvement over the original. -- To view, visit http://gerrit.ovirt.org/37988 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86221e8af24da28a7137c0cc0e7aec69943a65c5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
