Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: refactor use of PatternFly grid classes ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/37502/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java: Line 114: userNameEditor.addLabelStyleName(PatternflyConstants.COL_MD_2); Line 115: userNameEditor.addLabelStyleName(PatternflyConstants.CONTROL_LABEL); Line 116: userNameEditor.addLabelStyleName("white"); //$NON-NLS-1$ Line 117: userNameEditor.addContentWidgetContainerStyleName(PatternflyConstants.COL_SM_10); Line 118: userNameEditor.addContentWidgetContainerStyleName(PatternflyConstants.COL_MD_10); > Yeah. I'm not sure about every element -- technically you're supposed to pu Basically your container is layed out into 12 columns, then you can add rows to the container. Then you add columns to the rows (each column is a container itself). You assigned how many columns of the container you want your column to occupy. That way you can make nested containers and each one will have a consistent width. Its very helpful in laying out elements without having to be pixel perfect as the layout is done for you. Line 119: Line 120: passwordEditor.addLabelStyleName(PatternflyConstants.COL_SM_2); Line 121: passwordEditor.addLabelStyleName(PatternflyConstants.COL_MD_2); Line 122: passwordEditor.addLabelStyleName(PatternflyConstants.CONTROL_LABEL); -- To view, visit http://gerrit.ovirt.org/37502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7eb9241a8800343174d2e23cbd33c26b9fe31f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
