Lior Vernia has posted comments on this change. Change subject: userportal, webadmin: refactor use of PatternFly grid classes ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/37502/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/AbstractLoginFormView.java: Line 110: informationMessagePanel.setVisible(false); Line 111: passwordEditor.setAutoComplete("off"); //$NON-NLS-1$ Line 112: Line 113: userNameEditor.addLabelStyleName(PatternflyConstants.COL_SM_2); Line 114: userNameEditor.addLabelStyleName(PatternflyConstants.COL_MD_2); Out of curiosity, how is the screen size resolved? Is our project already running on both small and medium screens? Line 115: userNameEditor.addLabelStyleName(PatternflyConstants.CONTROL_LABEL); Line 116: userNameEditor.addLabelStyleName("white"); //$NON-NLS-1$ Line 117: userNameEditor.addContentWidgetContainerStyleName(PatternflyConstants.COL_SM_10); Line 118: userNameEditor.addContentWidgetContainerStyleName(PatternflyConstants.COL_MD_10); Line 114: userNameEditor.addLabelStyleName(PatternflyConstants.COL_MD_2); Line 115: userNameEditor.addLabelStyleName(PatternflyConstants.CONTROL_LABEL); Line 116: userNameEditor.addLabelStyleName("white"); //$NON-NLS-1$ Line 117: userNameEditor.addContentWidgetContainerStyleName(PatternflyConstants.COL_SM_10); Line 118: userNameEditor.addContentWidgetContainerStyleName(PatternflyConstants.COL_MD_10); So I'll be able to implement such layouts myself - what basically happens in Bootstrap is that *every* UI element is divided into 12 columns and they're divided among the elements it comprises? And here the content widget container gets 10/12 of userNameEditor's total width, with the label taking 2/12? Line 119: Line 120: passwordEditor.addLabelStyleName(PatternflyConstants.COL_SM_2); Line 121: passwordEditor.addLabelStyleName(PatternflyConstants.COL_MD_2); Line 122: passwordEditor.addLabelStyleName(PatternflyConstants.CONTROL_LABEL); -- To view, visit http://gerrit.ovirt.org/37502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7eb9241a8800343174d2e23cbd33c26b9fe31f2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
