Alexander Wels has posted comments on this change. Change subject: userportal, webadmin: refactor use of PatternFly grid classes ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/37502/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java: Line 39: * </p> Line 40: * <p> Line 41: * To enable PatternFly mode, call setUsePatternFly(true). You'll also probably want to set Line 42: * PatternFly grid classes on both the label and the widget container. E.g: <br/> Line 43: * addLabelStyleName(PatternFlyContants.COL-SM-2);<br/> You probably should update this to match reality. Line 44: * addContentWidgetContainerStyleName(PatternFlyContants.COL-SM-10);<br/> Line 45: * </p> Line 46: * @param <W> Line 47: * Content widget type. Line 108: protected void initWidget(Widget wrapperWidget) { Line 109: super.initWidget(wrapperWidget); Line 110: contentWidgetContainer.setWidget(contentWidget); Line 111: Line 112: labelElement.addClassName("labelEnabled"); //$NON-NLS-1$ Combined with the comment in the ui binder, you should be able to add back the labelEnabled/disabled in the style and use style.XX Line 113: Line 114: // Assign ID to content widget element if it's missing or empty Line 115: Element contentWidgetElement = getContentWidgetElement(); Line 116: if (contentWidgetElement.getId() == null || contentWidgetElement.getId().isEmpty()) { http://gerrit.ovirt.org/#/c/37502/4/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.ui.xml File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.ui.xml: Line 6: .wrapper_legacy { Line 7: line-height: 30px; Line 8: text-align: left; Line 9: } Line 10: I would do something like this for the labelEnabled/labelDisabled classes @external labelEnabled; .labelEnabled { } @external labelDisabled; .labelDisabled { } this will cause GWT to not obfuscate the name of the classes. Line 11: .label_legacy { Line 12: font-size: 13px; Line 13: padding: 0 5px; Line 14: font-family: Arial, sans-serif; -- To view, visit http://gerrit.ovirt.org/37502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7eb9241a8800343174d2e23cbd33c26b9fe31f2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
