Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: refactor use of PatternFly grid classes ......................................................................
Patch Set 3: (4 comments) http://gerrit.ovirt.org/#/c/37502/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/PatternflyConstants.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/PatternflyConstants.java: Line 2: Line 3: public class PatternflyConstants { Line 4: public static final String FORM_CONTROL = "form-control"; //$NON-NLS-1$ Line 5: public static final String FORM_GROUP = "form-group"; //$NON-NLS-1$ Line 6: public static final String CONTROL_LABEL = "control-label"; //$NON-NLS-1$ > All of these are defined in org.gwtbootstrap3.client.ui.constants.Styles Look at you reading documentation. Awesome -- fixed. Line 7: Line 8: Line 9: // bootstrap grid classes Line 10: public static final String COL_SM_1 = "col-sm-1"; //$NON-NLS-1$ Line 6: public static final String CONTROL_LABEL = "control-label"; //$NON-NLS-1$ Line 7: Line 8: Line 9: // bootstrap grid classes Line 10: public static final String COL_SM_1 = "col-sm-1"; //$NON-NLS-1$ > All of these are defined in the ColumnSize enum from gwt-bootstrap. Done. File can be deleted now. Line 11: public static final String COL_SM_2 = "col-sm-2"; //$NON-NLS-1$ Line 12: public static final String COL_SM_3 = "col-sm-3"; //$NON-NLS-1$ Line 13: public static final String COL_SM_4 = "col-sm-4"; //$NON-NLS-1$ Line 14: public static final String COL_SM_5 = "col-sm-5"; //$NON-NLS-1$ http://gerrit.ovirt.org/#/c/37502/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java: Line 132: public void setUsePatternFly(final boolean usePatternFly) { Line 133: Line 134: // clear out styles Line 135: setWrapperStyleName(""); //$NON-NLS-1$ Line 136: setContentWidgetContainerStyleName(""); //$NON-NLS-1$ > I don't think we want to clear out the existing styles. What if someone has Done Line 137: setContentWidgetContainerStyleName(""); //$NON-NLS-1$ Line 138: setLabelStyleName(""); //$NON-NLS-1$ Line 139: Line 140: // add proper styles Line 145: else { Line 146: addContentWidgetContainerStyleName(style.contentWidget()); Line 147: addWrapperStyleName(style.wrapper()); Line 148: } Line 149: addContentWidgetContainerStyleName("avw_contentWidget_pfly_fix"); //$NON-NLS-1$ > Do these need to be added all the time even if patternfly is enabled? Nope. Fixed. Line 150: addWrapperStyleName("avw_wrapper_pfly_fix"); //$NON-NLS-1$ Line 151: addLabelStyleName(style.label()); Line 152: addLabelStyleName(style.labelEnabled()); Line 153: } -- To view, visit http://gerrit.ovirt.org/37502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie7eb9241a8800343174d2e23cbd33c26b9fe31f2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
