Alona Kaplan has posted comments on this change.

Change subject: backend: Add HostDev passthrough support #1
......................................................................


Patch Set 14:

(1 comment)

http://gerrit.ovirt.org/#/c/35892/14/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoDbFacadeImpl.java
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoDbFacadeImpl.java:

Line 64:         public HostDevice mapRow(ResultSet rs, int rowNum) throws 
SQLException {
Line 65:             HostDevice device = new HostDevice();
Line 66: 
Line 67:             device.setHostId(getGuid(rs, "host_id"));
Line 68:             device.setDeviceName(rs.getString("device_name"));
There is no setting for the capability. I causes the devices to be always 
marked for update.
Line 69:             
device.setParentDeviceName(rs.getString("parent_device_name"));
Line 70:             device.setIommuGroup((Integer) 
rs.getObject("iommu_group"));
Line 71:             device.setProductName(rs.getString("product_name"));
Line 72:             device.setProductId(rs.getString("product_id"));


-- 
To view, visit http://gerrit.ovirt.org/35892
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5575c0db797d7d04339c4b309bb4325e853ffed
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to