Martin Betak has posted comments on this change. Change subject: backend: Add HostDev passthrough support #1 ......................................................................
Patch Set 14: -Verified (4 comments) http://gerrit.ovirt.org/#/c/35892/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RefreshHostCapabilitiesCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RefreshHostCapabilitiesCommand.java: Line 15: Line 16: @NonTransactiveCommandAttribute Line 17: public class RefreshHostCapabilitiesCommand<T extends VdsActionParameters> extends RefreshHostInfoCommandBase<T> { Line 18: Line 19: public RefreshHostCapabilitiesCommand(T parameters) { > Please add RefreshHostInfoCommandBase(T parameters, CommandContext context) You probably meant this comment for RefreshHostDevicesCommand since that one is called internally by InitVdsOnUpCommand. Added the ctor there. Line 20: super(parameters); Line 21: } Line 22: Line 23: @Override http://gerrit.ovirt.org/#/c/35892/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RefreshHostInfoCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RefreshHostInfoCommandBase.java: Line 11: } Line 12: Line 13: @Override Line 14: protected boolean canDoAction() { Line 15: return validate(hostExists()) && validate(hostStatusValid()); > RefreshHostDevicesCommand is executed internally when activating the host. Done Line 16: } Line 17: Line 18: private ValidationResult hostExists() { Line 19: return getVds() == null ? new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NOT_EXIST) : ValidationResult.VALID; http://gerrit.ovirt.org/#/c/35892/14/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/HostDeviceDaoDbFacadeImpl.java: Line 64: public HostDevice mapRow(ResultSet rs, int rowNum) throws SQLException { Line 65: HostDevice device = new HostDevice(); Line 66: Line 67: device.setHostId(getGuid(rs, "host_id")); Line 68: device.setDeviceName(rs.getString("device_name")); > There is no setting for the capability. I causes the devices to be always m Done Line 69: device.setParentDeviceName(rs.getString("parent_device_name")); Line 70: device.setIommuGroup((Integer) rs.getObject("iommu_group")); Line 71: device.setProductName(rs.getString("product_name")); Line 72: device.setProductId(rs.getString("product_id")); http://gerrit.ovirt.org/#/c/35892/14/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsProperties.java: Line 397: public static final String VENDOR_ID = "vendor_id"; Line 398: public static final String VM_ID = "vmId"; Line 399: public static final String PARENT_NAME = "parent"; Line 400: public static final String PHYSICAL_FUNCTION = "physfn"; Line 401: public static final String TOTAL_VFS = "total_vfs"; > The vdsm is reporting "totalvfs". Please remove the '_'. Done Line 402: Line 403: // fencing policy parameters Line 404: public static final String STORAGE_DOMAIN_HOST_ID_MAP = "storageDomainHostIdMap"; Line 405: -- To view, visit http://gerrit.ovirt.org/35892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5575c0db797d7d04339c4b309bb4325e853ffed Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
