Alona Kaplan has posted comments on this change. Change subject: backend: Add HostDev passthrough support #1 ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/35892/14/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RefreshHostInfoCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RefreshHostInfoCommandBase.java: Line 11: } Line 12: Line 13: @Override Line 14: protected boolean canDoAction() { Line 15: return validate(hostExists()) && validate(hostStatusValid()); RefreshHostDevicesCommand is executed internally when activating the host. Since the new host status (up) is not commited in this stage, the canDo fails (hostStatusValid() = false). Maybe avoid executing the canDoAction of RefreshHostDevicesCommand in case of internalExecution. Line 16: } Line 17: Line 18: private ValidationResult hostExists() { Line 19: return getVds() == null ? new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_HOST_NOT_EXIST) : ValidationResult.VALID; -- To view, visit http://gerrit.ovirt.org/35892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5575c0db797d7d04339c4b309bb4325e853ffed Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
