Arik Hadas has posted comments on this change. Change subject: backend: Add HostDev passthrough support #1 ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/35892/12/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 1855: List<HostDevice> devices = new ArrayList<>(); Line 1856: Line 1857: for (Entry<String, Map<String, Object>> entry : deviceList.entrySet()) { Line 1858: Line 1859: Map<String, Object> params = (Map<String, Object>) entry.getValue().get(VdsProperties.PARAMS); > what about replacing also the Object with String? is it possible? I see tha never mind, ignore this comment and keep it as is Line 1860: String deviceName = entry.getKey(); Line 1861: Line 1862: HostDevice device = new HostDevice(); Line 1863: device.setDeviceName(entry.getKey()); -- To view, visit http://gerrit.ovirt.org/35892 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5575c0db797d7d04339c4b309bb4325e853ffed Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
