Shireesh Anjal has posted comments on this change.

Change subject: engine: Get Host fingerprint query
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetServerFingerprintQueryTest.java
Line 34:     private void setupMock() throws Exception {
Line 35:         IConfigUtilsInterface confInstance = new 
DefaultValuesConfigUtil();
Line 36:         Config.setConfigUtils(confInstance);
Line 37: 
Line 38:         
when(wrapper.getServerKeyFingerprint(serverName)).thenReturn(fingerPrint);
Inside executeQueryCommand, you are creating a new instance of VdsInstallerSSH. 
So how does this mocking help?
Line 39:     }
Line 40: 
Line 41:     @Test
Line 42:     public void testExecuteQueryCommnad() {


--
To view, visit http://gerrit.ovirt.org/7034
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8241e54a6f1b6d649a0c23f18ef6ba216670f005
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to