Dhandapani Gopal has posted comments on this change. Change subject: engine: Get Host fingerprint query ......................................................................
Patch Set 1: (6 inline comments) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetHostFingerprintQuery.java Line 10: public class GetHostFingerprintQuery<P extends GlusterHostQueryParameters> extends GlusterQueriesCommandBase<P> { Done Line 12: VdsInstallerSSH wrapper; Done Line 20: wrapper = new VdsInstallerSSH(); Done .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetHostFingerprintQueryTest.java Line 27: Done Line 49: getQuery().executeQueryCommand(); Mocked the ssh fingerprint, so that it wont execute the actual SSH connection. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java Line 279: GetGlusterHosts, Removed the GetGlusterHosts. -- To view, visit http://gerrit.ovirt.org/7034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8241e54a6f1b6d649a0c23f18ef6ba216670f005 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgo...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com> Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches