Shireesh Anjal has posted comments on this change.
Change subject: engine: Get Host fingerprint query
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetHostFingerprintQuery.java
Line 10: public class GetHostFingerprintQuery<P extends
GlusterHostQueryParameters> extends GlusterQueriesCommandBase<P> {
This is s generic query to fetch fingerprint of given server, and not specific
to Gluster. So it should use a parameters class that takes only server name/ip.
Also it need not extend from GlusterQueriesCommandBase.
Line 12: VdsInstallerSSH wrapper;
I don't see why this should be a class level variable.
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetHostFingerprintQueryTest.java
Line 27:
What is the purpose of the three class level variables params, wrapper, config ?
Line 49: getQuery().executeQueryCommand();
This will actually invoke the SSH connection, and would fail if the SSH service
is not running on the server where the test is running.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
Line 279: GetGlusterHosts,
GetGlusterHosts should be added in the patch that has corresponding query class.
--
To view, visit http://gerrit.ovirt.org/7034
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8241e54a6f1b6d649a0c23f18ef6ba216670f005
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
