Alon Bar-Lev has posted comments on this change.

Change subject: engine: Get Host fingerprint query
......................................................................


Patch Set 1: (2 inline comments)

I would love to see this fingerprint feature on regular host as well, it is not 
gluster specific feature.

....................................................
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetHostFingerprintQuery.java
Line 20:         wrapper = new VdsInstallerSSH();
Must call shutdown on finally.

....................................................
File 
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetHostFingerprintQueryTest.java
Line 49:         getQuery().executeQueryCommand();
There is a new class SSHD that provides SSH server for tests.

--
To view, visit http://gerrit.ovirt.org/7034
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8241e54a6f1b6d649a0c23f18ef6ba216670f005
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Selvasundaram <sesub...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to