Roy Golan has posted comments on this change. Change subject: Wrong field check leads to unusable controllers ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34528/1/mom/Monitor.py File mom/Monitor.py: Line 105: except Exception: Line 106: self.logger.exception("Unexpected collection error") Line 107: Line 108: if not set(data).issubset(self.fields): Line 109: self._set_not_ready("Incomplete data: missing %s" % \ I need to fit that message as well Line 110: (self.fields - set(data))) Line 111: return None Line 112: Line 113: # put None to all unset (optional) fields -- To view, visit http://gerrit.ovirt.org/34528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I631056568b5a69e18f6ed02730c41ab59f460aad Gerrit-PatchSet: 1 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
