Roy Golan has posted comments on this change. Change subject: GuestMemory fields should be optional ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/34528/4/mom/Collectors/GuestMemory.py File mom/Collectors/GuestMemory.py: Line 26 Line 27 Line 28 Line 29 Line 30 > You ignored my comment about having getStatsFields return 'swap_total' and libvirt will never supply those fields so I don't see the logic behind putting them in libvirtInterface http://gerrit.ovirt.org/#/c/34528/4/mom/Entity.py File mom/Entity.py: Line 106: if x.get(name, None) is not None] Line 107: for row in nonEmptyStats: Line 108: total = total + row[name] Line 109: if (len(nonEmptyStats) == 0): Line 110: return float(0) > Actually, I'm not sure I support the use of None at all. and what will be default values for balloon? if we use 0 I think we will end up inflating the balloon and loosing memory for that vm. if a given policy can check for None values, it could skip execution so in case guest-agent is missing we skip the balloon, but not the CpuTune. Line 111: else: Line 112: return float(total / len(nonEmptyStats)) Line 113: Line 114: def SetVar(self, name, val): -- To view, visit http://gerrit.ovirt.org/34528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I631056568b5a69e18f6ed02730c41ab59f460aad Gerrit-PatchSet: 4 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
