Yedidyah Bar David has posted comments on this change. Change subject: core: alert if executing with a non-string in env ......................................................................
Patch Set 1: btw, instead of rejecting immediately, we can try to convert to string, so that e.g. None will become 'None'. Not sure that's better. IMO every such case is a bug that needs fixing, no reason to hide it. If you do want to, can be done to fail optionally, so that automated testing will fail it but for users we'll "try to do our best"... but then might fail due to something else, as it's still a bug. One other case like that (I only remember these two): https://bugzilla.redhat.com/1101001 -- To view, visit http://gerrit.ovirt.org/34486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d79c4e29451779a0d98942de3bca1525a15c0ab Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
