Sandro Bonazzola has posted comments on this change. Change subject: core: alert if executing with a non-string in env ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/34486/1/src/otopi/plugin.py File src/otopi/plugin.py: Line 792: ): Line 793: raise RuntimeError( Line 794: _( Line 795: "executeRaw called with a non-string value in " Line 796: "the environment for the key '{k}'" > Not sure exactly what you want. We never say "please contact support", iirc what about using a debug line with key, type and value content and then raise RuntimeError with just "Internal error: can't execute {executable} with given arguments, see log for more details" ? Line 797: ).format( Line 798: k=k, Line 799: ) Line 800: ) -- To view, visit http://gerrit.ovirt.org/34486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d79c4e29451779a0d98942de3bca1525a15c0ab Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
