Yedidyah Bar David has posted comments on this change. Change subject: core: alert if executing with a non-string in env ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/34486/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-10-26 17:10:29 +0200 Line 4: Commit: Yedidyah Bar David <d...@redhat.com> Line 5: CommitDate: 2014-10-26 17:21:29 +0200 Line 6: Line 7: core: alert if executing with a non-string in env > non string *key* No, non-string value. See the example I gave in the "Verified" comment. I admit checking non-string key can be useful too, never happened to me yet... Line 8: Line 9: Related-To: https://bugzilla.redhat.com/1155596 Line 10: Change-Id: I8d79c4e29451779a0d98942de3bca1525a15c0ab http://gerrit.ovirt.org/#/c/34486/1/src/otopi/plugin.py File src/otopi/plugin.py: Line 792: ): Line 793: raise RuntimeError( Line 794: _( Line 795: "executeRaw called with a non-string value in " Line 796: "the environment for the key '{k}'" > this is going to user, you should provide something that is probably unders Not sure exactly what you want. We never say "please contact support", iirc. I do not think outputing the actual type/value is very useful, and might be too long. Line 797: ).format( Line 798: k=k, Line 799: ) Line 800: ) -- To view, visit http://gerrit.ovirt.org/34486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d79c4e29451779a0d98942de3bca1525a15c0ab Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
