Yedidyah Bar David has posted comments on this change. Change subject: core: alert if executing with a non-string in env ......................................................................
Patch Set 1: Alon: No problem keeping non-string in otopi env, but can't pass them (or any other non-string) to execve's env. Sandro: I deliberately did the test/raise after the writing to debug. I do not really mind about the text, feel free to suggest something specific. Main criteria (imo) - should be "unique-enough" (to ease searching in logs/google/bugzilla). -- To view, visit http://gerrit.ovirt.org/34486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d79c4e29451779a0d98942de3bca1525a15c0ab Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
