Alon Bar-Lev has posted comments on this change. Change subject: aaa: Fix group name issues for legacy provider ......................................................................
Patch Set 3: (1 comment) looks ok, not sure what left to fix there... I would have just moved the backend interaction into the utils as well. http://gerrit.ovirt.org/#/c/32652/3/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUsersResource.java: Line 168: Line 169: @Override Line 170: public Response add(User user) { Line 171: validateParameters(user, "userName"); Line 172: List<String> authzProvidersNames = getBackendCollection( this can go into the utils as well, no? Line 173: String.class, Line 174: VdcQueryType.GetDomainList, Line 175: new VdcQueryParametersBase()); Line 176: if (AuthzUtils.getAuthzNameFromEntityName(user.getUserName(), authzProvidersNames) == null) {// user-name may contain the domain (e.g: ol...@xxx.yyy) -- To view, visit http://gerrit.ovirt.org/32652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c1feed08e33156c794b230fa04f33f2ebd82240 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
