Yair Zaslavsky has posted comments on this change. Change subject: aaa: Fix group name issues for legacy provider ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/32652/4/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/aaa/AuthzUtils.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/aaa/AuthzUtils.java: Line 13: return result; Line 14: } Line 15: Line 16: Line 17: public static String getEntityNameWithoutAuthz(String entityName) { > you should do this here as well, no? not exactly, here i should pass another String - authzProviderName. Thanks Line 18: return entityName != null && entityName.contains("@") ? entityName.substring(0, entityName.lastIndexOf('@')) : entityName; Line 19: } -- To view, visit http://gerrit.ovirt.org/32652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c1feed08e33156c794b230fa04f33f2ebd82240 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
