Alon Bar-Lev has posted comments on this change. Change subject: aaa: Fix group name issues for legacy provider ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/32652/5/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/aaa/AuthzUtils.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/aaa/AuthzUtils.java: Line 14: } Line 15: Line 16: Line 17: public static String getEntityNameWithoutAuthz(String entityName, String authzProviderName) { Line 18: String result = entityName; > I think you can do lastIndex once per this function, even the substring... s/authzCandidate.equals(authzProviderName)/authzProviderName.equals(authzCandidate)/ Line 19: if (entityName != null && entityName.contains("@") && entityName.lastIndexOf('@') < entityName.length() -1) { Line 20: result = entityName.substring(entityName.lastIndexOf('@')+1).equals(authzProviderName) ? entityName.substring(0, entityName.lastIndexOf('@')) : entityName; Line 21: } Line 22: return result; -- To view, visit http://gerrit.ovirt.org/32652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c1feed08e33156c794b230fa04f33f2ebd82240 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
