Alon Bar-Lev has posted comments on this change. Change subject: aaa: Fix group name issues for legacy provider ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/32652/2/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/AuthzUtils.java File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/AuthzUtils.java: Line 1: package org.ovirt.engine.api.restapi.utils; can we have this in aaa package? Line 2: Line 3: public class AuthzUtils { Line 4: Line 5: public static String getAuthzNameFromEntityName(String entityName) { Line 7: } Line 8: Line 9: Line 10: public static String getEntityNameWithoutAuthz(String entityName) { Line 11: return getAuthzNameFromEntityName(entityName) != null ? entityName.substring(0, entityName.lastIndexOf('@')) : entityName; won't it better to do this as we done in other locations? I mean to return the @xxx only if xxx matches one of the authz? Line 12: } -- To view, visit http://gerrit.ovirt.org/32652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c1feed08e33156c794b230fa04f33f2ebd82240 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
