Yedidyah Bar David has posted comments on this change. Change subject: core: rewrite buildSequence using toposort ......................................................................
Patch Set 3: > as I explained the priority is a hint per design, it is here to stay, at > least in this major. I didn't see any design document. If there is an event using 'HIGH - 10' and another one using 'HIGH', I bet you never intended for them to be able to switch places. I never saw the following reasoning, just guessing it from the changes done to this code as can be seen in git: First there were Stage and Priority. This worked well enough for some time. If you wanted something to happen before something else, you gave them priorities so that this is what will happen. 'HIGH' and 'HIGH - 10' was the only way. And it worked. Then you decided that this isn't enough, and added Before/After. The right thing to do was probably to give at least one of the 'HIGH', 'HIGH - 10' events a name, and add Before or After to the other. But this wasn't really needed, because things simply worked. But not well enough. Not for me, at least. -- To view, visit http://gerrit.ovirt.org/28775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a7e9a26ac68543331dc869ab151883ac8bd5b30 Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
