Yedidyah Bar David has posted comments on this change. Change subject: core: rewrite buildSequence using toposort ......................................................................
Patch Set 3: Is there a specific reason why priority is lower priority than before/after? Not just that "it's by the design". A reason. Is there? In other words: Is there a reason to not enforce both? Only recently I pushed Id0f2f9d55ffbab69f0c8b74b003295fc65cfc90b to fix logs of engine-cleanup. Without it, under certain conditions, the logs could have been written to /tmp. With toposort this can't happen anymore, but it can still happen with the existing code, even with this addition. Is that really by design? -- To view, visit http://gerrit.ovirt.org/28775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a7e9a26ac68543331dc869ab151883ac8bd5b30 Gerrit-PatchSet: 3 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
