Sandro Bonazzola has posted comments on this change. Change subject: core: rewrite buildSequence using toposort ......................................................................
Patch Set 2: Verified-1 (1 comment) http://gerrit.ovirt.org/#/c/28775/2/src/otopi/toposort.py File src/otopi/toposort.py: Line 57: v.discard(k) Line 58: # Find all items that don't depend on anything. Line 59: extra_items_in_deps = _reduce(set.union, data.values()) - set(data.keys()) Line 60: # Add empty dependences where needed. Line 61: data.update({item:set() for item in extra_items_in_deps}) ^^ above line doesn't work with python 2.6 Line 62: while True: Line 63: ordered = set(item for item, dep in data.items() if len(dep) == 0) Line 64: if not ordered: Line 65: break -- To view, visit http://gerrit.ovirt.org/28775 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a7e9a26ac68543331dc869ab151883ac8bd5b30 Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Lev Veyde <lve...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
