Yedidyah Bar David has posted comments on this change.

Change subject: core: rewrite buildSequence using toposort
......................................................................


Patch Set 3:

In current implementation:

Priority is not enforced:

- It's currently just a hint, simply defining the initial order.

- We do rely on it in a few cases.

- Before/After and Stage silently overrule priority.

Before/After are not enforced:

- Stage silently overrules Before/After.

It's not deterministic:

- Example: A "working" set of events can become non-working ("loop detected") 
merely by removing parts of it. This is today much a larger problem than it was 
in the past, because setup now has many more optional components.

-- 
To view, visit http://gerrit.ovirt.org/28775
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a7e9a26ac68543331dc869ab151883ac8bd5b30
Gerrit-PatchSet: 3
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Lev Veyde <lve...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to