Ofer Schreiber has posted comments on this change.
Change subject: packaging: adding functionality to MYUM class
......................................................................
Patch Set 2: Fails
(6 inline comments)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 344: if len(pkglist) > 0:
just return len(pkglist) > 0
Line 354: if len(pkglist) > 0:
same
Line 364: raise Exception("Error: pkgs variable sent to
depListForRemoval function must be of a list type.")
I don't think this is really needed
Line 376: logging.debug(traceback.format_exc())
logging.error
Line 377: logging.debug("Couldn't create a list of deps to remove")
missing end raise (actually, I'm not sure we really want this try/catch
Line 379: return deplist
you should do self.yumbase.closeRpmDB() before return to clean transaction (or
have a separate function for that)
--
To view, visit http://gerrit.ovirt.org/6203
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib26e517771d24242c1279358563dba74aca7cade
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
