Doron Fediuck has posted comments on this change.
Change subject: core: block vm migration if cpu pinning enabled
......................................................................
Patch Set 11: I would prefer that you didn't submit this
(5 inline comments)
Hi Laszlo,
A few changes still needed, including a change in the default value I asked for
a while ago.
Please see recent comments on this set, as well as Yair's previous comments.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1167: @DefaultValueAttribute("false")
Laszlo, this should be set to "TRUE" as a default value.
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 156: ACTION_TYPE_FAILED_VM_CANNOT_BE_PINNED_TO_CPU_AND_MIGRATABLE=VM's
pinned to CPU can not be migrated.
The logic is reversed.
It should be:
Migratable VM's cannot be pinned to CPU.
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 154: ACTION_TYPE_FAILED_VM_CANNOT_BE_PINNED_TO_CPU_AND_MIGRATABLE=VM's
pinned to CPU can not be migrated.
The logic is reversed. It should be: Migratable VM's cannot be pinned to CPU.
....................................................
File
frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 1:
DIRECTORY_GROUP_CANNOT_REMOVE_DIRECTORY_GROUP_ATTACHED_TO_VM_POOL=Cannot remove
Directory Group attached to VM Pool
Please remove this whole file.
....................................................
File
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
Line 153: ACTION_TYPE_FAILED_VM_CANNOT_BE_PINNED_TO_CPU_AND_MIGRATABLE=VM's
pinned to CPU can not be migrated.
The logic is reversed. It should be: Migratable VM's cannot be pinned to CPU.
--
To view, visit http://gerrit.ovirt.org/5065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38e7585d96ff0c5d5ea29222495b8d987f6aeb7b
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
