Doron Fediuck has posted comments on this change.
Change subject: core: block vm migration if cpu pinning enabled
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
Laszlo, the new message you added needs a text in all relevant properties
files. Also, the default value should be changed. See inline.
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/config.sql
Line 25: select
fn_db_add_config_value('CpuPinMigrationEnabled','false','general');
Default value should be true.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1152: @DefaultValueAttribute("false")
should be true. thanks!
--
To view, visit http://gerrit.ovirt.org/5065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38e7585d96ff0c5d5ea29222495b8d987f6aeb7b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
