Doron Fediuck has posted comments on this change.

Change subject: core: block vm migration if cpu pinning enabled
......................................................................


Patch Set 3: I would prefer that you didn't submit this

(2 inline comments)

Laszlo,
Please add the error message text to the relevant properties file. Also, there 
a slite spelling issue, see inline.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
Line 75:         final boolean cpuPingMigrationEnabled = 
Boolean.TRUE.equals(Config.<Boolean> 
GetValue(ConfigValues.CpuPinMigrationEnabled));
s/
cpuPingMigrationEnabled/
cpuPinMigrationEnabled

Line 76:         if (!cpuPingMigrationEnabled
same fix needed here.

--
To view, visit http://gerrit.ovirt.org/5065
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38e7585d96ff0c5d5ea29222495b8d987f6aeb7b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to