Yair Zaslavsky has posted comments on this change.
Change subject: core: block vm migration if cpu pinning enabled
......................................................................
Patch Set 6: (2 inline comments)
Minor comments , and waiting for the app errors stuff , as Doron mentioned.
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/config.sql
Line 25: select
fn_db_add_config_value('CpuPinMigrationEnabled','true','general');
Laszlo,
Is it relevant also for 3.0 ? Not so sure, why not add this for 3.1 only?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java
Line 78: && StringUtils.isNotEmpty(cpuPinning)) {
Thank you for using StringUtils of apache ;)
--
To view, visit http://gerrit.ovirt.org/5065
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I38e7585d96ff0c5d5ea29222495b8d987f6aeb7b
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
