Moti Asayag has posted comments on this change.

Change subject: engine: Configure unique host name on neutron.conf
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.ovirt.org/#/c/28791/6//COMMIT_MSG
Commit Message:

Line 21: So the engine should be able to define a unique host name for each
Line 22: agent, first for the agent which reports its name to the neutron node,
Line 23: and later-on when port are allocated on each agent.
Line 24: 
Line 25: Since the host name is unique, and could be changed only by 
> -
Done
Line 26: re-installing the host, it makes sense to use it as the agent name.
Line 27: 
Line 28: Change-Id: I18db7cce8769b23b1fafcf5ac31ebdb7556a7cec


Line 22: agent, first for the agent which reports its name to the neutron node,
Line 23: and later-on when port are allocated on each agent.
Line 24: 
Line 25: Since the host name is unique, and could be changed only by 
Line 26: re-installing the host, it makes sense to use it as the agent name.
> Just to make sure... again... sorry I bother, but this is non standard...
no bother at all - those are perfectly valid questions.

1. Yes

2. step by step:
 a. host 'H1' added and removed --> agent named 'H1' added to neutron.
 b. host renamed to 'H2' and added to engine again --> agent named 'H1' still 
exist on neutron
 c. host 'H1' added to neutron --> agent 'H1' on neutron was updated to match 
the reported host. So eventually, on neutron there will be a single server.

I'd expect that on b. the added host 'H2' will be installed with the external 
provider, which lead to adding the agent as 'H2' on neutron.

3. Yes, but it makes the debug less intuitive, see the output of the agents on 
neutron by "neutron agent-list":
http://hastebin.com/ipaselonad.avrasm
Line 27: 
Line 28: Change-Id: I18db7cce8769b23b1fafcf5ac31ebdb7556a7cec


-- 
To view, visit http://gerrit.ovirt.org/28791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18db7cce8769b23b1fafcf5ac31ebdb7556a7cec
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to