Alon Bar-Lev has posted comments on this change. Change subject: engine: Configure unique host name on neutron.conf ......................................................................
Patch Set 8: (1 comment) nice! minor comment. http://gerrit.ovirt.org/#/c/28791/8/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java: Line 273: /** Line 274: * @return A unique host name representation Line 275: */ Line 276: public static String getUniqueHostName(VDS host) { Line 277: return host.getHostName() + "-" + new String(DigestUtils.md5Hex(host.getId().toByteArray())).substring(0, 6); if md5Hex returns string, why do you need new String? but if you use new String on byte array... you should use explicit encoding. Line 278: } -- To view, visit http://gerrit.ovirt.org/28791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18db7cce8769b23b1fafcf5ac31ebdb7556a7cec Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
