Alon Bar-Lev has posted comments on this change. Change subject: engine: Configure unique host name on neutron.conf ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/28791/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java: Line 497: new Callable<Boolean>() {@CallWhen(CustomizationCondition.NEUTRON_SETUP) Line 498: public Boolean call() throws Exception { Line 499: _parser.cliEnvironmentSet( Line 500: OpenStackEnv.NEUTRON_CONFIG_PREFIX + "DEFAULT/host", Line 501: _vds.getHostName() without knowing what it does, I would like to warn that the way engine see the hostname of vdsm can and most probably differ from what host may thing. I am not sure this is valid as configuration within host. please confirm you know what you are doing :) Line 502: ); Line 503: return true; Line 504: }}, Line 505: new Callable<Boolean>() {@CallWhen(CustomizationCondition.NEUTRON_SETUP) -- To view, visit http://gerrit.ovirt.org/28791 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I18db7cce8769b23b1fafcf5ac31ebdb7556a7cec Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
