Alon Bar-Lev has posted comments on this change.

Change subject: engine: Configure unique host name on neutron.conf
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/28791/6//COMMIT_MSG
Commit Message:

Line 22: agent, first for the agent which reports its name to the neutron node,
Line 23: and later-on when port are allocated on each agent.
Line 24: 
Line 25: Since the host name is unique, and could be changed only by 
Line 26: re-installing the host, it makes sense to use it as the agent name.
> no bother at all - those are perfectly valid questions.
2. ok, so as far as neutron is concerned last wins... no authentication or 
something... I can report that I am "God" and it will accept that? sounds bit 
strange to me. but you can have two hosts reporting by the same name 
eventually... so what will happen exactly?

3. I get empty content at this url. However, I would have considered something 
like ${hostname}-substring(md5sum(${unique_id}), 0, 6).
Line 27: 
Line 28: Change-Id: I18db7cce8769b23b1fafcf5ac31ebdb7556a7cec


-- 
To view, visit http://gerrit.ovirt.org/28791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I18db7cce8769b23b1fafcf5ac31ebdb7556a7cec
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to