Alon Bar-Lev has posted comments on this change. Change subject: kdump: Add kdump plugin ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/28385/2/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 56: _FK_OPTS_REGEX = re.compile( Line 57: flags=re.VERBOSE, Line 58: pattern=r""" Line 59: ^ Line 60: (?P<key>(\#\ oVirt\ backup\:\ )?fence_kdump_(nodes|args)) > Well I did this in one regexp, because I need only 4 specific lines from th please separate between the regexp of comments and the regexp of key, value Line 61: [ ] Line 62: (?P<value>.*) Line 63: $ Line 64: """ Line 57: flags=re.VERBOSE, Line 58: pattern=r""" Line 59: ^ Line 60: (?P<key>(\#\ oVirt\ backup\:\ )?fence_kdump_(nodes|args)) Line 61: [ ] > According to docs \s is any whitespace character [ \t\n\r\f\v] regexp is per line so it is not \n in our case you mean \t is not supported? Line 62: (?P<value>.*) Line 63: $ Line 64: """ Line 65: ) Line 85: full_distribution_name=0 Line 86: ) Line 87: Line 88: if name in ('redhat', 'centos') and version.startswith('6.'): Line 89: return '2.0.0-274.el6' > I cannot, because in RHEL 7.0 there is kexec-tools 2.0.4-32.el7, but fence_ ok, so you need to remove the .el6 anyway, check for version only, and disable your self if not supported. also please avoid return at middle of functions. it should be: version = None if distribution in ('redhat', 'centos'): if distributionVersion.splt('.')[0] = '6': version = '2.0.0-274' elif distribution == 'fedora': version = '2.0.4-27' return version Line 90: Line 91: elif name == 'fedora' and version == '20': Line 92: return '2.0.4-27.fc20' Line 93: -- To view, visit http://gerrit.ovirt.org/28385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idda48cb053c7e8747de5434c3681403f739c06b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
