Alon Bar-Lev has posted comments on this change. Change subject: kdump: Add kdump plugin ......................................................................
Patch Set 2: (2 comments) I asked for a complete configuration... please send me via email... I do not understand these snips. but from what I do understand, we only need to put our lines, regardless of what there, as this configuration does not support multiple profiles anyway. http://gerrit.ovirt.org/#/c/28385/2/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 56: _FK_OPTS_REGEX = re.compile( Line 57: flags=re.VERBOSE, Line 58: pattern=r""" Line 59: ^ Line 60: (?P<key>(\#\ oVirt\ backup\:\ )?fence_kdump_(nodes|args)) > I need to know, if we already created backup of our changes or not. And our this is a different regexp Line 61: [ ] Line 62: (?P<value>.*) Line 63: $ Line 64: """ Line 57: flags=re.VERBOSE, Line 58: pattern=r""" Line 59: ^ Line 60: (?P<key>(\#\ oVirt\ backup\:\ )?fence_kdump_(nodes|args)) Line 61: [ ] > Well, kexec-tools internal parsing requires space char between option and v \s is space Line 62: (?P<value>.*) Line 63: $ Line 64: """ Line 65: ) -- To view, visit http://gerrit.ovirt.org/28385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idda48cb053c7e8747de5434c3681403f739c06b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
