Martin Peřina has posted comments on this change. Change subject: kdump: Add kdump plugin ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/28385/2/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 49: KdumpEnv.MESSAGE_INTERVAL -- interval between fence_kdump messages Line 50: Line 51: """ Line 52: Line 53: _KEXEC_TOOLS_RPM = 'kexec-tools' > s/RPM/PACKAGE/ as we do like to support other distributions, Done Line 54: Line 55: # pattern to match lines with fence_kdump configuration Line 56: _FK_OPTS_REGEX = re.compile( Line 57: flags=re.VERBOSE, Line 85: full_distribution_name=0 Line 86: ) Line 87: Line 88: if name in ('redhat', 'centos') and version.startswith('6.'): Line 89: return '2.0.0-274.el6' > check only minimum version, drop the el6, what you care is that you have yo I cannot, because in RHEL 7.0 there is kexec-tools 2.0.4-32.el7, but fence_kdump pacthes are not included in this version. So I have to distinguish between el6 and el7. Line 90: Line 91: elif name == 'fedora' and version == '20': Line 92: return '2.0.4-27.fc20' Line 93: Line 88: if name in ('redhat', 'centos') and version.startswith('6.'): Line 89: return '2.0.0-274.el6' Line 90: Line 91: elif name == 'fedora' and version == '20': Line 92: return '2.0.4-27.fc20' > same here... no sense checking fedora-20, only if version is >= what we nee Done Line 93: Line 94: raise RuntimeError( Line 95: _( Line 96: 'Kdump detection is not currently supported in: ' -- To view, visit http://gerrit.ovirt.org/28385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idda48cb053c7e8747de5434c3681403f739c06b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
