Alon Bar-Lev has posted comments on this change. Change subject: kdump: Add kdump plugin ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28385/1/src/plugins/ovirt-host-deploy/kdump/packages.py File src/plugins/ovirt-host-deploy/kdump/packages.py: Line 51: _KEXEC_TOOLS_RPM = 'kexec-tools' Line 52: Line 53: # min version of kexec-tools per distribution Line 54: _FC20_MIN_VER = '2.0.4-27.fc20' Line 55: _EL6_MIN_VER = '2.0.0-274.el6' > Ahh, do you mean something like: well, I thought of something simpler... 1. perform package detection, if you find valid package, set environment with KDUMP_SUPPORTED 2. at engine, enable kdump only if SUPPORTED and should be enabled. Line 56: Line 57: # prefixes marking changes by oVirt Line 58: _OVIRT_BACKUP_NODES = '# oVirt backup: fence_kdump_nodes ' Line 59: _OVIRT_BACKUP_ARGS = '# oVirt backup: fence_kdump_args ' -- To view, visit http://gerrit.ovirt.org/28385 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idda48cb053c7e8747de5434c3681403f739c06b1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
