Daniel Erez has posted comments on this change. Change subject: jsonrpc: Stomp changes in vdsbroker ......................................................................
Patch Set 14: Code-Review+1 (1 comment) reviewed frontend http://gerrit.ovirt.org/#/c/26783/14/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java: Line 908: host.setVdsName(model.getName().getEntity()); Line 909: host.setComment(model.getComment().getEntity()); Line 910: host.setHostName(model.getHost().getEntity()); Line 911: host.setPort(Integer.parseInt(model.getPort().getEntity().toString())); Line 912: host.setProtocol(VdsProtocol.fromValue(model.getProtocol().getEntity() ? VdsProtocol.STOMP.toString() the convention is to keep the values on a single line - i.e. '? VdsProtocol.STOMP.toString(): VdsProtocol.XML.toString()));' Line 913: : VdsProtocol.XML.toString())); Line 914: host.setSshPort(Integer.parseInt(model.getAuthSshPort().getEntity().toString())); Line 915: boolean sshUsernameSet = model.getUserName().getEntity() != null; Line 916: host.setSshUsername(sshUsernameSet ? model.getUserName().getEntity() : null); -- To view, visit http://gerrit.ovirt.org/26783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If78de6620ba6891543531ac8ddd633b67828a89c Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
