Oved Ourfali has posted comments on this change. Change subject: jsonrpc: Stomp changes in vdsbroker ......................................................................
Patch Set 13: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/26783/13/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EngineManagerProvider.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EngineManagerProvider.java: Line 20: return EngineEncryptionUtils.getKeyManagers(); Line 21: } Line 22: Line 23: @Override Line 24: public TrustManager[] getTustManagers() throws GeneralSecurityException { you have a typo here. I guess you meant getTrustManagers Line 25: return EngineEncryptionUtils.getTrustManagers(); Line 26: } Line 27: http://gerrit.ovirt.org/#/c/26783/13/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIntegrationTest.java File backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIntegrationTest.java: Line 14: Line 15: @Ignore Line 16: public class JsonRpcIntegrationTest { Line 17: Line 18: private final static String HOST_ADDRESS = "192.168.1.10"; Do we still need this tester? won't work using this address. Unless I'm missing something. Line 19: private final static int PORT = 4044; Line 20: private final static int TIMEOUT = 5000; Line 21: Line 22: @Test -- To view, visit http://gerrit.ovirt.org/26783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If78de6620ba6891543531ac8ddd633b67828a89c Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
