Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: Stomp changes in vdsbroker ......................................................................
Patch Set 13: (2 comments) http://gerrit.ovirt.org/#/c/26783/13/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EngineManagerProvider.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/EngineManagerProvider.java: Line 20: return EngineEncryptionUtils.getKeyManagers(); Line 21: } Line 22: Line 23: @Override Line 24: public TrustManager[] getTustManagers() throws GeneralSecurityException { > you have a typo here. I guess you meant getTrustManagers Good catch will update. Line 25: return EngineEncryptionUtils.getTrustManagers(); Line 26: } Line 27: http://gerrit.ovirt.org/#/c/26783/13/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIntegrationTest.java File backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcIntegrationTest.java: Line 14: Line 15: @Ignore Line 16: public class JsonRpcIntegrationTest { Line 17: Line 18: private final static String HOST_ADDRESS = "192.168.1.10"; > Do we still need this tester? won't work using this address. Unless I'm mis You are right. I used it to make sure that the integration works between java and vdsm without running the engine. As you can see the test is @ignored but when someone will work on transport layer in the future can update address and test his changes by talking to real vdsm without running really heavy engine after each modification. I still think that there is a value in having this test in the source tree. Line 19: private final static int PORT = 4044; Line 20: private final static int TIMEOUT = 5000; Line 21: Line 22: @Test -- To view, visit http://gerrit.ovirt.org/26783 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If78de6620ba6891543531ac8ddd633b67828a89c Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
