Yair Zaslavsky has posted comments on this change. Change subject: aaa: Changes to ExtensionsManager ......................................................................
Patch Set 20: (1 comment) http://gerrit.ovirt.org/#/c/27785/20/backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java File backend/manager/modules/extensions-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionsManager.java: Line 225: } Line 226: } catch (Exception e) { Line 227: throw new RuntimeException(String.format("Error loading extension %1$s", entry.name)); Line 228: } Line 229: loadedEntries.putIfAbsent(entry.name, entry); > please put extension only after all is set including global context. Done Line 230: synchronized (globalContext) { Line 231: globalContext.<List<ExtMap>> get(Base.GlobalContextKeys.EXTENSIONS).add( Line 232: new ExtMap().mput( Line 233: Base.ExtensionRecord.INSTANCE_NAME, -- To view, visit http://gerrit.ovirt.org/27785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c914df29a0dbf52ff6d2f8149687b31b4faffe1 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
